Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show system status in Settings/General #27238

Merged
merged 3 commits into from
Feb 27, 2017
Merged

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Feb 23, 2017

@PVince81

Description

The status query is moved into a fuction making it available to be regualry called.
Printout of system details as you would see them like in status.php
Adding additional elements in the status query does not need additional code changes in the template.

Related Issue

#27231

Motivation and Context

This PR shows the elements like you see in ownclouddomain.com/status.php at the bottom of Settings/General

How Has This Been Tested?

call /settings/admin?sectionid=general and move to the bottom to see the result

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@mmattel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bantu, @butonic and @DeepDiver1975 to be potential reviewers.

@tomneedham tomneedham mentioned this pull request Feb 23, 2017
9 tasks
@mmattel
Copy link
Contributor Author

mmattel commented Feb 23, 2017

Why did jenkins fail?

@PVince81
Copy link
Contributor

Seems you added a new public method:

@since or @deprecated tag is needed in PHPDoc for OCP\Util::getStatusInfo

you need to add @since 10.0 in its PHPDoc

@PVince81 PVince81 added this to the 10.0 milestone Feb 27, 2017
@PVince81
Copy link
Contributor

Tested, works. 👍

@Emil-G
Copy link

Emil-G commented Jul 12, 2017

May I ask why the servername was not added to the admin pages as well?
cheers,
Emil

@PVince81
Copy link
Contributor

@Emil-G the admin page simply outputs whatever values are in status.php. If no server name is visible in status.php then it won't be visible there.

But maybe you meant to add it as additional info on this page regardless of status.php ? (the intent here was only about status.php)

@Emil-G
Copy link

Emil-G commented Jul 12, 2017

@PVince81 yes, that is what I was asking. That would be useful admin info when servers are clustered.

@PVince81
Copy link
Contributor

@Emil-G raised here #28382

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants