Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: Sharing via email-link + password: Add “wrong credentials” message #2725

Closed
farson2003 opened this issue Apr 4, 2013 · 7 comments · Fixed by #3914
Closed

Comments

@farson2003
Copy link

When sharing a file via email-link and password, the receiver must enter a password.

When the receiver enters a wrong password or no password at all, the page simply reloads without any message such as “Correct password required”.

I think it would be good to have a little balloon or something, stating that the correct password is required to proceed.

So this is a feature proposal.

@MTGap
Copy link
Contributor

MTGap commented May 2, 2013

@jancborchardt Any thoughts? "Correct password required" sounds funny :)

@jancborchardt
Copy link
Member

When thinking about error messages, always think about how you would say it to friends.

I’d say: »The password is wrong. Try again«

@tanghus
Copy link
Contributor

tanghus commented May 2, 2013

»The password is wrong. Try again«

»Error 40: Self-destruction sequence activated«

@jancborchardt
Copy link
Member

»You typed in a wrong password you stupid idiot. Now because you can’t do anything right, we just deleted the file completely. You can clear that up with the person who shared the link with you. Good luck, dumbass.«

@tanghus
Copy link
Contributor

tanghus commented May 3, 2013

Even better :D

@jancborchardt
Copy link
Member

@MTGap missed the base on this one – does the message I suggested suffice, or is there already a pull request?
Better even: »Sorry, but the password seems to be wrong. Please double-check and try again.«

@MTGap
Copy link
Contributor

MTGap commented May 10, 2013

Haven't worked on it yet. Junior Job?

Niduroki pushed a commit that referenced this issue Jul 2, 2013
for the public share was wrong.

Fix #2725
Niduroki pushed a commit that referenced this issue Aug 16, 2013
for the public share was wrong.

Fix #2725
@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants