-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload button tooltip doesn't disappear #7461
Comments
Hello, I am interested in contributing to ownCloud and I thought fixing this issue would be a good place to start. Do you agree @karlitschek? If so, feel free to assign me to the bug. |
@oskholl yes, this is a good place to start. :) Github doesn’t let us assign you to the issue but that’s ok. Simply prepare a pull request with the fix and mention me (with @jancborchardt) in it. If you have any questions please ask. And if you use IRC, join us in #owncloud-design (and #owncloud-dev) on freenode. Cheers! |
@oskholl are you still interested in this? :) Please ask if you have any questions. |
Sorry about the delay @jancborchardt, I am interested. I am having troubles setting up git version of ownCloud. Stable version installs fine but with the git version I get only blank page. Once I figure this out, I will try to fix the problem. |
@oskholl do you have the 3rdparty submodule installed? (git submodule init, then git submodule update) |
@jancborchardt I finally managed to setup the git version with the help of someone on IRC. The issue is not limited to the text editor -- in fact it happens whatever viewer is open. I tried PDF and ODF so far. I shall try to find the solution soon. |
@oskholl yes, would be cool if you find a solution. :) And great that you got help on IRC – you can always ask there or here if you have questions. |
@jancborchardt I think I solved it, I have sent the pull request. I apologise if I broke some naming conventions. Please tell me if I did something wrong. Thank you. And I am sorry about those extra commits, I was just trying to revert my first half-working solution. |
Fixes issue owncloud#7461. Tipsy tooltip must be hidden when the upload starts. Otherwise it covers the progress bar and stays in DOM.
@oskholl yeah, everything is fine. :) Good code comment, proper pull request flow, and it’s merged in. Thank you! :) I’m closing this issue hence. Come join us on the developer mailing list at http://mailman.owncloud.org/mailman/listinfo/devel and in the IRC channel #owncloud-dev (on freenode network). |
Expected behaviour
Tooltip (max upload...) disappears, when the text editor is opened.
Actual behaviour
The tooltip stays stable in position and sometimes, it can cover the "save" button. If the file is closed by "close" button of text editor, this tooltip is still there. But if the text editor is closed by unnormal way like click "home" icon, toolbars on the left side, this tooltip can finally disappear.
Steps to reproduce
Server configuration
Operating system: ubuntu 12.10
Web server: apache 2.2
Database: SQLite
PHP version: 5.4.6
ownCloud version: 6.0.2rc
Updated from an older ownCloud or fresh install: no
List of activated app:standard apps of owncloud 6.0.1
The content of config/config.php: (Without the database password and passwordsalt)
CONFIG = array (
'instanceid' => 'oc6d9cda6e26',
'datadirectory' => '/var/www/owncloud602rc/data',
'dbtype' => 'sqlite3',
'version' => '6.0.2.0',
'installed' => true,
'theme' => '',
'maintenance' => false,
'maxZipInputSize' => 838860800,
'allowZipDownload' => true,
'loglevel' => '0',
);
Are you using external storage, if yes which one: no
Client configuration
Browser: firefox 27.0.1
Operating system: ubuntu 12.04
Logs
Web server error log
ownCloud log (data/owncloud.log)
The text was updated successfully, but these errors were encountered: