Fix: 'Upload button tooltip doesn't disappear' #7814
Conversation
Fixes issue owncloud#7461. Tipsy tooltip must be hidden when the upload starts. Otherwise it covers the progress bar and stays in DOM.
|
The automatic check found 2 issues but it also says 2 issues fixed. Is it ok or should I change anything @PVince81? |
|
I don't know why Scrutinizer is complaining about a line unrelated to this commit, but you might want to put the comments on a separate line to get rid of the line length warning. Perhaps someone more knowledgeable than I (@PVince81?) could clarify this. Other than that, looks like this is ready to go. |
|
The inspection completed: No new issues |
|
🚀 Test Passed. 🚀 |
|
@Xenopathic Just ignore it, it's not critical 😉 @oskholl thanks for the cleaner PR. Code looks good, will test this soon. |
|
It seems to work. But I remember that the original issue was hard to produce anyway, just happened randomly. This needs another reviewer @MorrisJobke @Xenopathic @Kondou-ger @jancborchardt |
|
@PVince81 I was able to reproduce the error always (at least in Firefox). After upload, the tooltip would go away only if the mouse was hovered over the upload button. Moreover, it always covered the progress bar. |
|
Indeed. I tried again, it seems to be a Firefox thing. Your fix fixes that. |
|
That was my working theory:) |
|
@PVince81 Thought so :) |
|
Works just fine 👍 I will remove the executable flag from the file once this is merged. |
Fix: 'Upload button tooltip doesn't disappear'
|
@karlitschek backport to stable 6 ? |
|
Yes. backport would be great |
|
stable6 backport: f82aed0 |
Fixes issue #7461. Tipsy tooltip must be hidden when the upload starts. Otherwise it covers the progress bar and stays in DOM. Please review @PVince81 @jancborchardt.