-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom have to be set at 90% to be able to take away external storage settings #9612
Comments
@blizzz @jancborchardt Can you have a look please? |
This part of the UI probably needs to be redesigned. @enoch85 do you at least see an horizontal scrollbar ? |
@PVince81 No, no horizontal scrollbar either. |
Okay, that's a problem them. What browser ? Chrome or Firefox ? |
I use Chrome Version 35.0.1916.153 m |
Indeed, it looks like the horizontal scroll bar has been removed. I know horizontal scrollbars are evil but it's even worse if people can't reach the delete button. |
I specifically enabled the scrollbar for the Personal and Admin page in a past pull request - strange that it doesn't work. To make sure, can we add a class to the body of each of the settings pages? So in addition to the id="body-settings" we should add class="body-settings-personal" for example. |
Reopening because #9653 doesn't fixes the issue for all widths, some narrower widths still have an unreachable trash icon. |
For external storage with lots of parameter settings (>4), wrap the content of the cell to let a full view of the parameters. The rows of the table are now always visible until the end (the trash icon is accessible). (Note : A strange 3px margin forces me to add a class on the row added by javascript, to be able to align them with the rows rendered by the server.)
@PVince81 Your remark is correct. But this applies for all the settings page, because the horinzontal scroll bar is gone. I prefer to add the horinzalt scrollbar back, than to shrink this external storage table until a width of 180 px ... ;-) I don't see the point to get the whole settings page should be accessible for 180px screens without an horinzontal scrollbar. For me this bug is closed. Your point is more general and requires a more global discussion... (?) |
I agree with the horizontal scrollbar. The problem is that when I tested I did not see such scrollbar and was not able to reach the trash icon, even with your patch applied. So I wanted to keep this ticket here open to add back the horizontal scrollbar. |
Is this fixed? |
@jancborchardt is this fixed? |
Yes – was fixed and backported through #10703 |
With Chrome 100% you can´t reach the trashcan button. Screen resolution is set to 1366x768.
(oC Daily Build)
The text was updated successfully, but these errors were encountered: