Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom have to be set at 90% to be able to take away external storage settings #9612

Closed
enoch85 opened this issue Jul 13, 2014 · 13 comments
Closed

Comments

@enoch85
Copy link
Member

enoch85 commented Jul 13, 2014

image

With Chrome 100% you can´t reach the trashcan button. Screen resolution is set to 1366x768.

(oC Daily Build)

@karlitschek
Copy link
Contributor

@blizzz @jancborchardt Can you have a look please?

@PVince81
Copy link
Contributor

This part of the UI probably needs to be redesigned.
Some ext storage backends have lots of options that don't fit on the screen.

@enoch85 do you at least see an horizontal scrollbar ?

@enoch85
Copy link
Member Author

enoch85 commented Jul 14, 2014

@PVince81 No, no horizontal scrollbar either.

@PVince81
Copy link
Contributor

Okay, that's a problem them.
In my case I was always able to horizontally scroll to the right to delete external storage.

What browser ? Chrome or Firefox ?

@enoch85
Copy link
Member Author

enoch85 commented Jul 14, 2014

I use Chrome Version 35.0.1916.153 m

@PVince81
Copy link
Contributor

Indeed, it looks like the horizontal scroll bar has been removed.
@jancborchardt can we add it back for the admin and personal page ?

I know horizontal scrollbars are evil but it's even worse if people can't reach the delete button.
We can look into wrapping those fields neatly in OC 8.

@jancborchardt
Copy link
Member

I specifically enabled the scrollbar for the Personal and Admin page in a past pull request - strange that it doesn't work.

To make sure, can we add a class to the body of each of the settings pages? So in addition to the id="body-settings" we should add class="body-settings-personal" for example.

@PVince81
Copy link
Contributor

Reopening because #9653 doesn't fixes the issue for all widths, some narrower widths still have an unreachable trash icon.

@PVince81 PVince81 reopened this Jul 16, 2014
ghost pushed a commit that referenced this issue Jul 16, 2014
For external storage with lots of parameter settings (>4), wrap the content of the cell to let a full view of the parameters.
The rows of the table are now always visible until the end (the trash icon is accessible).
(Note : A strange 3px margin forces me to add a class on the row added by javascript, to be able to align them with the rows rendered by the server.)
@ghost
Copy link

ghost commented Jul 17, 2014

@PVince81 Your remark is correct. But this applies for all the settings page, because the horinzontal scroll bar is gone.

I prefer to add the horinzalt scrollbar back, than to shrink this external storage table until a width of 180 px ... ;-) I don't see the point to get the whole settings page should be accessible for 180px screens without an horinzontal scrollbar.

For me this bug is closed. Your point is more general and requires a more global discussion... (?)

@PVince81
Copy link
Contributor

I agree with the horizontal scrollbar. The problem is that when I tested I did not see such scrollbar and was not able to reach the trash icon, even with your patch applied.

So I wanted to keep this ticket here open to add back the horizontal scrollbar.

@enoch85
Copy link
Member Author

enoch85 commented Aug 31, 2014

Is this fixed?

@MTRichards
Copy link
Contributor

@jancborchardt is this fixed?

@craigpg craigpg modified the milestones: need more information, ownCloud 7.0.2, 2014-sprint-03-current Sep 2, 2014
@jancborchardt jancborchardt self-assigned this Sep 3, 2014
@jancborchardt
Copy link
Member

Yes – was fixed and backported through #10703

@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants