Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ast.php #10122

Merged
merged 1 commit into from
Aug 4, 2014
Merged

Update ast.php #10122

merged 1 commit into from
Aug 4, 2014

Conversation

malditoastur
Copy link

Following the thread in:

#10112

I modify this file hoping to be included in next ownCloud 7.0.x version. (Please, I don't have enough github knowledgment. Sorry if i'm doing something wrong..)

Following the thread in:

owncloud#10112

I modify this file hoping to be included in next ownCloud 7.0.x version. (Please, I don't have enough github knowledgment. Sorry if i'm doing something wrong..)
@ghost
Copy link

ghost commented Aug 2, 2014

Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@DeepDiver1975
Copy link
Member

@owncloud-bot this is okay to test

@vgezer
Copy link
Contributor

vgezer commented Aug 2, 2014

@malditoastur Please add a comment stating the contribution is MIT licensed so we can merge it.

@DeepDiver1975
Copy link
Member

@owncloud-bot retest this please

@ghost
Copy link

ghost commented Aug 3, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/6522/

@DeepDiver1975
Copy link
Member

👍

1 similar comment
@MorrisJobke
Copy link
Contributor

👍

MorrisJobke added a commit that referenced this pull request Aug 4, 2014
@MorrisJobke MorrisJobke merged commit ed89a74 into owncloud:stable7 Aug 4, 2014
@vgezer
Copy link
Contributor

vgezer commented Aug 4, 2014

@MorrisJobke Don't we wait for the license text or is this OK because it's only a translation?

@DeepDiver1975
Copy link
Member

Don't we wait for the license text or is this OK because it's only a translation?

Generally speaking: yes - we require the license statement - in this case it doesn't really matter.
Anyway @wakeup Thanks for taking care!

@MorrisJobke
Copy link
Contributor

@wakeup @DeepDiver1975 I think the translations licence is handled in transifex and therefore it's okay to merge this here

@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants