remove css not selector - incompatible with ie8 #1061

Merged
merged 1 commit into from Jan 7, 2013

4 participants

@butonic
ownCloud member

the 'not' selector is only supported since IE9+, we are overriding the checkbox margin and with later anyway, so this should not produce any regressions

@butonic
ownCloud member

@DeepDiver1975 do you know who I can notify for ie8 testing?

@DeepDiver1975
ownCloud member

me 😈

@DeepDiver1975
ownCloud member

tested in the login screen 👍
any other screen to test?

@tanghus tanghus commented on the diff Jan 2, 2013
core/css/styles.css
@@ -34,7 +34,7 @@ filter:progid:DXImageTransform.Microsoft.gradient( startColorstr='#35537a', endC
/* INPUTS */
input[type="text"], input[type="password"] { cursor:text; }
-input:not([type="checkbox"]), textarea, select, button, .button, #quota, div.jp-progress, .pager li a {
+input, textarea, select, button, .button, #quota, div.jp-progress, .pager li a {
width:10em; margin:.3em; padding:.6em .5em .4em;
@tanghus
ownCloud member
tanghus added a note Jan 2, 2013

This will break other browsers. 10em wide checkboxes don't look that cool ;)

@butonic
ownCloud member
butonic added a note Jan 2, 2013

in line 51 there is a input[type="checkbox"] { margin:0; padding:0; height:auto; width:auto; } which overrides this one. the other browsers will not suffer from this. It is basically redundant.

@tanghus
ownCloud member
tanghus added a note Jan 2, 2013

Maybe also simply remove width:10em;. I see no need for it in a what should be a generic stylesheet.

@butonic
ownCloud member
butonic added a note Jan 2, 2013

@jancborchardt how can we systematically clean up the css? any ideas? you ok with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@tanghus
ownCloud member

Sorry 👎 Is there a way we can make a fallback for IE8 that won't break it for other browsers @jancborchardt ?

btw, shouldn't it be input:not([type="checkbox"]):not([type="radio"])?

@DeepDiver1975
ownCloud member
@tanghus
ownCloud member

Interesting. Especially because it would only load in the crappy browsers.

@butonic
ownCloud member

@tanghus before starting to add fallbacks shouldn't we first/finally add Modernizr? @karlitschek what is the status there?

@tanghus
ownCloud member

@butonic Eh, I kinda promised to submit a pull request on that, but I blame it on the holidays ;)

@jancborchardt
ownCloud member

Big thanks @butonic! I actually discovered I can’t get the Windows machine I have access to to run IE8. Do we have any remotely accessible virtual machines for testing?

@butonic
ownCloud member

@jancborchardt @tanghus do you give me your 👍 as this currently fixes the css?

@tanghus
ownCloud member

👍

@butonic butonic merged commit 3dbb148 into master Jan 7, 2013

1 check passed

Details default Merged build finished.
@DeepDiver1975 DeepDiver1975 deleted the remove_css_not_selector_to_fix_ie8_input_fields branch Jan 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment