remove css not selector - incompatible with ie8 #1061
Conversation
|
@DeepDiver1975 do you know who I can notify for ie8 testing? |
|
me 😈 |
|
tested in the login screen 👍 |
| @@ -34,7 +34,7 @@ filter:progid:DXImageTransform.Microsoft.gradient( startColorstr='#35537a', endC | |||
|
|
|||
| /* INPUTS */ | |||
| input[type="text"], input[type="password"] { cursor:text; } | |||
| input:not([type="checkbox"]), textarea, select, button, .button, #quota, div.jp-progress, .pager li a { | |||
| input, textarea, select, button, .button, #quota, div.jp-progress, .pager li a { | |||
| width:10em; margin:.3em; padding:.6em .5em .4em; | |||
There was a problem hiding this comment.
This will break other browsers. 10em wide checkboxes don't look that cool ;)
There was a problem hiding this comment.
in line 51 there is a input[type="checkbox"] { margin:0; padding:0; height:auto; width:auto; } which overrides this one. the other browsers will not suffer from this. It is basically redundant.
There was a problem hiding this comment.
Maybe also simply remove width:10em;. I see no need for it in a what should be a generic stylesheet.
There was a problem hiding this comment.
@jancborchardt how can we systematically clean up the css? any ideas? you ok with this PR?
|
Sorry 👎 Is there a way we can make a fallback for IE8 that won't break it for other browsers @jancborchardt ? btw, shouldn't it be |
|
Is that a possible solution: http://dean.edwards.name/weblog/2010/03/ie7js-update/ |
|
Interesting. Especially because it would only load in the crappy browsers. |
|
@tanghus before starting to add fallbacks shouldn't we first/finally add Modernizr? @karlitschek what is the status there? |
|
@butonic Eh, I kinda promised to submit a pull request on that, but I blame it on the holidays ;) |
|
Big thanks @butonic! I actually discovered I can’t get the Windows machine I have access to to run IE8. Do we have any remotely accessible virtual machines for testing? |
|
@jancborchardt @tanghus do you give me your 👍 as this currently fixes the css? |
|
👍 |
…_ie8_input_fields remove css not selector - incompatible with ie8
DeepDiver1975
deleted the
remove_css_not_selector_to_fix_ie8_input_fields
branch
the 'not' selector is only supported since IE9+, we are overriding the checkbox margin and with later anyway, so this should not produce any regressions