Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove css not selector - incompatible with ie8 #1061

Merged
merged 1 commit into from Jan 7, 2013
Merged

remove css not selector - incompatible with ie8 #1061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/css/styles.css
View file
Open in desktop
Expand Up @@ -34,7 +34,7 @@ filter:progid:DXImageTransform.Microsoft.gradient( startColorstr='#35537a', endC

/* INPUTS */
input[type="text"], input[type="password"] { cursor:text; }
input:not([type="checkbox"]), textarea, select, button, .button, #quota, div.jp-progress, .pager li a {
input, textarea, select, button, .button, #quota, div.jp-progress, .pager li a {
width:10em; margin:.3em; padding:.6em .5em .4em;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break other browsers. 10em wide checkboxes don't look that cool ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in line 51 there is a input[type="checkbox"] { margin:0; padding:0; height:auto; width:auto; } which overrides this one. the other browsers will not suffer from this. It is basically redundant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also simply remove width:10em;. I see no need for it in a what should be a generic stylesheet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jancborchardt how can we systematically clean up the css? any ideas? you ok with this PR?

font-size:1em; font-family:Arial, Verdana, sans-serif;
background:#fff; color:#333; border:1px solid #ddd; outline:none;
Expand Down