Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[research] search API, webdav rfc5323 approach #12884

Closed
wants to merge 1 commit into from

Conversation

butonic
Copy link
Member

@butonic butonic commented Dec 16, 2014

Following the discussion in #12504 and #12543 I stated to work on a search API that is loosely based on RFC5323. I got as far as being able to use our search providers and even limiting results to a specific app. Unfortunately, we need to adapt the current search result object properties to webdav properties. For files that can be done with $this->server->getPropertiesForPath see diff but there needs to be an extendable way how to do that.

@butonic butonic changed the title [WIP] search API, webdav rfc5323 approach [research] search API, webdav rfc5323 approach Dec 16, 2014
*/
public $from;

public $where;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpdocs please

@MorrisJobke
Copy link
Contributor

@DeepDiver1975
Copy link
Member

This will be a valid approach to search in files - what about other resource?

I think we are not yet in the position to make a decision on this -> backlog

@DeepDiver1975
Copy link
Member

@butonic rebase??? 🙊

@DeepDiver1975 DeepDiver1975 added this to the backlog milestone Nov 12, 2015
@DeepDiver1975
Copy link
Member

Let's close this one for now - the whole webdav code base did change and it's highler unclear in which directions search will go. THX @butonic

@DeepDiver1975 DeepDiver1975 deleted the webdav_rfc5323_search branch February 3, 2016 16:52
@butonic
Copy link
Member Author

butonic commented Feb 3, 2016

agreed.

@butonic butonic mentioned this pull request May 24, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants