Update doctrine/dbal to 2.5.1 #13537

[VicDeo]

Closes #13303
Depends on owncloud-archive/3rdparty#152

Scheduled for 8.1

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9233/
Test PASSed.

[VicDeo]

@DeepDiver1975 as I said, it's enough to skip extra primary keys for the tests to pass.
Will check migration manually as well

[DeepDiver1975]

as I said, it's enough to skip extra primary keys for the tests to pass.

nice - thx

[VicDeo]

Manual migration from OC7 to this branch was successful for sqlite.
Common scenarios for indexes are covered already:
https://github.com/owncloud/core/blob/master/tests/lib/db/migrator.php

[VicDeo]

@DeepDiver1975 FYI this originated from SQLite autoincrement kinks http://www.doctrine-project.org/jira/browse/DBAL-188

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9580/
Test PASSed.

[scrutinizer-notifier]

The inspection completed: 1 updated code elements

[DeepDiver1975]

Unit tests on oracle just run fine 👍
Successful migration testing done as well 👍

[DeepDiver1975]

@icewind1991 please review - THX

[icewind1991]

Tested upgrade with pgsql, mysql and oracle, nothing seems to explode

👍

[AdamWill]

I've also done a quick test on this for Fedora packaging purposes, looks good for sqlite deployment so far, will be testing other DBs and 7.x upgrades soon.

[DeepDiver1975]

@VicDeo please create PRs in core and 3rdparty against stable8 branch to introduce dabl 2.5.1 - THX

[VicDeo]

@DeepDiver1975
done #14515

[DeepDiver1975]

THX

[AdamWill]

I've tested 8.0.0 plus the commit from this PR for clean deployment with sqlite, mariadb, and pgsql, and for upgrade with mysql using both a small test set of data and my production deployment: worked fine on all of them.