Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L10n fixes #16

Closed
wants to merge 10 commits into from
Closed

L10n fixes #16

wants to merge 10 commits into from

Conversation

scambra
Copy link

@scambra scambra commented Sep 21, 2012

Date in tooltip displayed in modification column is not translated, you must setlocale and use strftime to get month translations in PHP.

Also modification column is not translated when a file is created/uploaded, row is created with JS and relative date strings translations in files app was missing, although it's splitting sentences. I added support for sprintf and translation with arguments to JS, and reused relative date strings from lib.

And I added localization for datepicker too, which is used in set expiration date.

scambra added 4 commits September 21, 2012 07:28
Use locale date format with translated month names
Translate modification date when file is created/uploaded
@DeepDiver1975
Copy link
Member

Hi,
many thanks for this pull request.
Looks really great!

I'll merge this after 4.5 release.

Thx,

Tom

@ghost ghost assigned DeepDiver1975 Sep 21, 2012
@scambra
Copy link
Author

scambra commented Sep 21, 2012

Ok, I'm working in fixing some untranslated strings

@DeepDiver1975
Copy link
Member

Cool! Many thanks!
Untranslated strings are relevant for 4.5 from my point of view.
Just submit the pull requests - I'll take care!

Tom

@scambra
Copy link
Author

scambra commented Sep 21, 2012

Really all these commits are about untranslated strings, although first commits are not so simple because they are about date localization.

I have pushed changes in files_sharing to translate it, although perl l10n.pl read is not picking this one:
Shared with you and the group %s by %s

@DeepDiver1975
Copy link
Member

Sorry for being not precise enough:
For 4.5 I'm willing to accept simple changes like 'Password' -> t('core', 'Password')

And I need those in a separate pull request - this pull request will be for 5.0.

Regarding l10n.pl not catching your string: I have no idea and no time to take care - sorry. Maybe this is just another topic for 5.0

Many thanks again for your support,

Tom

@scambra
Copy link
Author

scambra commented Sep 21, 2012

I understand it, I will do a new request with simple changes for 4.5

@DeepDiver1975
Copy link
Member

@scambra: I just merged the pull request from Thomas Tanghus regarding js string interpolation.
Due to that and the fact that this pull request cannot be merged anymore automatically I kindly ask you to resubmit your pull request taking into account that we don't use sprtinf.js.

Your contribution is very welcome!

Thanks a lot,

Tom

PS:
I prefer multiple small pull requests instead of one big as reviewing them is easier! ;-)

THX

IljaN added a commit that referenced this pull request Mar 9, 2017
IljaN added a commit that referenced this pull request Mar 17, 2017
bhawanaprasain pushed a commit to JankariTech/core that referenced this pull request Apr 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants