Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support interpolation in js translations #18

Closed
wants to merge 3 commits into from
Closed

Support interpolation in js translations #18

wants to merge 3 commits into from

Conversation

scambra
Copy link

@scambra scambra commented Sep 26, 2012

I forgot this change in pull request for 4.5, some translation fixes pulled require this commit.

Support interpolation in js translations
3f8be29 
Translate modification date when file is created/uploaded
@scambra
Copy link
Author

scambra commented Sep 26, 2012

Also I have added some more interpolations in javascript translations

@DeepDiver1975
Copy link
Member

Hi,

as already stated in the pull request #16: this is a too big change for 4.5.
We need to postpone this until 5.0

I just recognized that the pull request #17 relies on interpolation.
We need to implement this without interpolation for 4.5

Thanks,

Tom

@ghost ghost assigned DeepDiver1975 Sep 26, 2012
@scambra scambra closed this Sep 26, 2012
@scambra
Copy link
Author

scambra commented Sep 26, 2012

I push the commits to the other branch then

@scambra
Copy link
Author

scambra commented Sep 26, 2012

Should I undo interpolation in js for 4.5? I thought you was talking about changing date localization when you said is too big

@DeepDiver1975
Copy link
Member

sorry for being no precise enough - yes please undo interpolation for 4.5

THX a lot,

Tom

@sghebuz sghebuz mentioned this pull request Mar 11, 2013
Closed
@jozefcernak jozefcernak mentioned this pull request Sep 22, 2013
Closed
@tanghus tanghus mentioned this pull request Sep 27, 2013
Merged
@PVince81 PVince81 mentioned this pull request Oct 8, 2013
Closed
@ghost ghost mentioned this pull request Jan 2, 2014
Closed
@enoch85 enoch85 mentioned this pull request Jul 23, 2014
Closed
@omarwllorente omarwllorente mentioned this pull request Jul 24, 2014
Closed
@actyler555 actyler555 mentioned this pull request Oct 21, 2014
Closed
aditmeno pushed a commit to aditmeno/Aeolus that referenced this pull request Apr 2, 2015
@DeepDiver1975
Merge pull request owncloud#18 from owncloud/fixing-sqlserver-master
63cb284 
Fixing sqlserver master
@muppeth muppeth mentioned this pull request May 15, 2015
Closed
@szepeviktor szepeviktor mentioned this pull request Aug 24, 2015
Closed
@ghost ghost mentioned this pull request Aug 28, 2015
Closed
@anduz anduz mentioned this pull request Oct 19, 2015
Closed
@Kaelber Kaelber mentioned this pull request Jan 18, 2016
Closed
@friedrico friedrico mentioned this pull request Jan 31, 2016
Closed
@tomghyselinck tomghyselinck mentioned this pull request Mar 14, 2016
Closed
@GitHubUser4234 GitHubUser4234 mentioned this pull request Apr 22, 2016
Closed
@Kaelber Kaelber mentioned this pull request May 9, 2016
Closed
@n3m3s1s n3m3s1s mentioned this pull request Jun 10, 2016
Closed
@sermilrod sermilrod mentioned this pull request Jun 25, 2016
Closed
This was referenced Jul 29, 2016
Closed
Closed
@farpet farpet mentioned this pull request Aug 8, 2016
Closed
@PVince81 PVince81 mentioned this pull request Aug 9, 2016
Closed
@osadmin osadmin mentioned this pull request Aug 16, 2016
Merged
kostas707 referenced this pull request Aug 23, 2016
@DeepDiver1975
Don't log credentials of LoginController::tryLogin - fixes #25895
b29f1c9
@kostas707 kostas707 mentioned this pull request Aug 23, 2016
Closed
@tonybluem tonybluem mentioned this pull request Sep 13, 2016
Closed
@signmeuptwice signmeuptwice mentioned this pull request Oct 14, 2016
Closed
@zjsywcc zjsywcc mentioned this pull request Nov 1, 2016
Closed
@stephan-l stephan-l mentioned this pull request Nov 4, 2016
Closed
@schachtnerth-zz schachtnerth-zz mentioned this pull request Nov 7, 2016
Closed
@turin13 turin13 mentioned this pull request Nov 23, 2016
Closed
@TDannhauer TDannhauer mentioned this pull request Nov 30, 2016
Closed
@jaceq jaceq mentioned this pull request Dec 13, 2016
Closed
@fsantiago07044 fsantiago07044 mentioned this pull request Feb 9, 2017
Closed
@happiness-now happiness-now mentioned this pull request Apr 22, 2017
Closed
@montanaviking montanaviking mentioned this pull request Apr 28, 2017
Closed
@raeisi raeisi mentioned this pull request May 29, 2017
Closed
@adrienafl adrienafl mentioned this pull request Jun 21, 2017
Closed
@ahmedatawfik ahmedatawfik mentioned this pull request Dec 11, 2017
Closed
@andriusign andriusign mentioned this pull request Dec 12, 2017
Closed
@mrow4a mrow4a mentioned this pull request Mar 4, 2018
Merged
9 tasks
@popsy700 popsy700 mentioned this pull request Apr 17, 2018
Closed
@CristianCardosoA CristianCardosoA mentioned this pull request Aug 8, 2018
Closed
@eorganicmart eorganicmart mentioned this pull request Oct 12, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scambra @DeepDiver1975