Remove hard-dependency on disabled output_buffering #16042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the hard-dependency on output buffering as requested at #16013 since a lot of distributions such as Debian and Ubuntu decided to use `4096` instead of the PHP recommended and documented default value of `off`. However, we still should encourage disabling this setting for improved performance and reliability thus the setting switches in `.user.ini` and `.htaccess` are remaining there. It is very likely that we in other cases also should disable the output buffering but aren't doing it everywhere and thus causing memory problems. Fixes #16013
|
A new inspection was created. |
|
as discussed 👍 |
|
Refer to this link for build results (access rights to CI server needed): |
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
May 4, 2015
Remove hard-dependency on disabled output_buffering
mmattel
pushed a commit
to mmattel/core
that referenced
this pull request
May 22, 2015
Remove hard-dependency on disabled output_buffering
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the hard-dependency on output buffering as requested at #16013 since a lot of distributions such as Debian and Ubuntu decided to use
4096instead of the PHP recommended and documented default value ofoff.However, we still should encourage disabling this setting for improved performance and reliability thus the setting switches in
.user.iniand.htaccessare remaining there. It is very likely that we in other cases also should disable the output buffering but aren't doing it everywhere and thus causing memory problems.Fixes #16013
cc @karlitschek @DeepDiver1975