Don't log expected Swift 404 responses in files_external #19000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File existence checks are expected in some cases to be false, so passing 404 Not Found errors through to the logs just causes noise.
|
A new inspection was created. |
|
@butonic what do you think? |
|
👍 |
|
@owncloud-bot This is okay to test. @DeepDiver1975 CLA bot? ;-) |
|
👍 |
|
wait for #14077, then rebase please |
|
I ran the unit tests locally and there were no unexpected new fails. |
DeepDiver1975
added a commit
that referenced
this pull request
Oct 29, 2015
…ted-404-errors Don't log expected Swift 404 responses in files_external
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File existence checks are expected in some cases to be false, so passing
404 Not Found errors through to the logs just causes noise.