New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating tags where another one with same prefix exists #22065
Conversation
When creating a new entry, compare the full tag name and not only the prefix.
By analyzing the blame information on this pull request, we identified @nickvergessen to be a potential reviewer |
👍 |
Tag is created, but previous one is unassigned. So you have to add the two tags again looking for them in the dropdown. |
PS: that happens when you use enter, clicking (which I did first) works, as it changes the selected row. |
Yeah, I'll need to hack select2 to properly render this item on top. |
@PVince81 any chance for 9.0.0 ? |
@PVince81 Status of this one? Still 9.0.1? |
I suggest we merge this first. The inconvenience is that the "to create" tag entry will not appear at the very top for some reason, so the user cannot hit "enter" to create it and must click on it directly. This is still better than not being able to create the tag at all. Please review. |
Tested and works 👍 |
@karlitschek backport to 9.0.1 ? |
please backport |
stable9: #23387 |
whats wrong with php 5.4 in here? |
PR is Javascript only |
Allow creating tags where another one with same prefix exists
fair enough 🙈 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When creating a new entry, compare the full tag name and not only the
prefix.
Fixes #22064
@SergioBertolinSG