Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating tags where another one with same prefix exists #22065

Merged
merged 1 commit into from Mar 21, 2016

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Feb 2, 2016

When creating a new entry, compare the full tag name and not only the
prefix.

Fixes #22064

@SergioBertolinSG

When creating a new entry, compare the full tag name and not only the
prefix.
@PVince81 PVince81 added this to the 9.0-current milestone Feb 2, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @nickvergessen to be a potential reviewer

@nickvergessen
Copy link
Contributor

👍

@SergioBertolinSG
Copy link
Contributor

Tag is created, but previous one is unassigned. So you have to add the two tags again looking for them in the dropdown.

@nickvergessen
Copy link
Contributor

PS: that happens when you use enter, clicking (which I did first) works, as it changes the selected row.

@PVince81
Copy link
Contributor Author

PVince81 commented Feb 2, 2016

Yeah, I'll need to hack select2 to properly render this item on top.

@nickvergessen
Copy link
Contributor

@PVince81 any chance for 9.0.0 ?

@PVince81 PVince81 modified the milestones: 9.0.1-next-maintenance, 9.0-current Feb 29, 2016
@MorrisJobke
Copy link
Contributor

@PVince81 Status of this one? Still 9.0.1?

@PVince81
Copy link
Contributor Author

I suggest we merge this first. The inconvenience is that the "to create" tag entry will not appear at the very top for some reason, so the user cannot hit "enter" to create it and must click on it directly.

This is still better than not being able to create the tag at all.

Please review.

@MorrisJobke
Copy link
Contributor

Tested and works 👍

@PVince81
Copy link
Contributor Author

@karlitschek backport to 9.0.1 ?

@PVince81 PVince81 modified the milestones: 9.1-current, 9.0.1-current-maintenance Mar 18, 2016
@karlitschek
Copy link
Contributor

please backport

@PVince81
Copy link
Contributor Author

stable9: #23387

@DeepDiver1975
Copy link
Member

whats wrong with php 5.4 in here?

@PVince81
Copy link
Contributor Author

whats wrong with php 5.4 in here?

PR is Javascript only

DeepDiver1975 added a commit that referenced this pull request Mar 21, 2016
Allow creating tags where another one with same prefix exists
@DeepDiver1975 DeepDiver1975 merged commit 86581f6 into master Mar 21, 2016
@DeepDiver1975 DeepDiver1975 deleted the systemtags-create-same-prefix branch March 21, 2016 10:15
@DeepDiver1975
Copy link
Member

PR is Javascript only

fair enough 🙈

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detection of existing tags doesn't allow to create tags named like a prefix substring of an existing tag.
7 participants