-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move setupfromtoken to sharemanager #24383
Conversation
By analyzing the blame information on this pull request, we identified @icewind1991, @PVince81 and @LukasReschke to be potential reviewers |
mmm I don't get why the intergration tests are failing... If I manually repeat those exact same steps it all works... |
a101fd8
to
2ced60f
Compare
@rullzer move to 9.2 ? |
Yeah non critical. Works as is this is just part of the ongoing sharing pimping. |
@@ -52,8 +57,6 @@ function() { | |||
->actionInclude('files_sharing/ajax/list.php'); | |||
$this->create('files_sharing_ajax_publicpreview', 'ajax/publicpreview.php') | |||
->actionInclude('files_sharing/ajax/publicpreview.php'); | |||
$this->create('sharing_external_shareinfo', '/shareinfo') | |||
->actionInclude('files_sharing/ajax/shareinfo.php'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, we might still need to keep this file for backwards compatibility with older OC servers
|
This is still used by the shareinfo.php endpoint. Which is an ajax endpoint.
|
2ced60f
to
0513cd7
Compare
to be redone |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
More for #22209
This moves over ajax/shareinfo.php to a controller. And updates this to use the sharemanager.
TODO: