Move setupfromtoken to sharemanager #24383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @icewind1991, @PVince81 and @LukasReschke to be potential reviewers |
|
mmm I don't get why the intergration tests are failing... If I manually repeat those exact same steps it all works... |
rullzer
force-pushed
the
move_setupfromtoken_to_sharemanager
branch
from
a101fd8
to
2ced60f
Compare
|
@rullzer move to 9.2 ? |
|
Yeah non critical. Works as is this is just part of the ongoing sharing pimping. |
| @@ -52,8 +57,6 @@ function() { | |||
| ->actionInclude('files_sharing/ajax/list.php'); | |||
| $this->create('files_sharing_ajax_publicpreview', 'ajax/publicpreview.php') | |||
| ->actionInclude('files_sharing/ajax/publicpreview.php'); | |||
| $this->create('sharing_external_shareinfo', '/shareinfo') | |||
| ->actionInclude('files_sharing/ajax/shareinfo.php'); | |||
There was a problem hiding this comment.
hmm, we might still need to keep this file for backwards compatibility with older OC servers
|
This is still used by the shareinfo.php endpoint. Which is an ajax endpoint.
|
PVince81
force-pushed
the
move_setupfromtoken_to_sharemanager
branch
from
2ced60f
to
0513cd7
Compare
|
to be redone |
10 tasks
14 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More for #22209
This moves over ajax/shareinfo.php to a controller. And updates this to use the sharemanager.
TODO: