Luckydonald superduper progressbar branch thingie #24605
Conversation
…kB of 3MB) and the current speed.
…d now unneeded speed div
Tooltips still frustrate me- And the updated code with tabs nicely. yay.
…eased buffer size to 20 to be less jittery.
…b.com/luckydonald/core into luckydonald-Superduper-Progressbar-branch-thingie
|
By analyzing the blame information on this pull request, we identified @jancborchardt, @MorrisJobke and @butonic to be potential reviewers |
|
License is MIT as stated here #10326 (comment) |
|
I was not able to see the "..seconds left" message in the progress bar or as a tooltip on it. Tested with Chrome and Firefox for MacOSX |
|
@davitol you need a slower computer, maybe a slow proxy of some sorts. |
|
Upload a bigger file maybe? |
|
Works here just fine 👍 |
| display: block !important; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
possibly yes when resolving the conflict, let me adjust this
There was a problem hiding this comment.
ah no, it's the end of the media query element
|
@PVince81 Could you hit the merge button? This is nearly only JS (and some template changes in a PHP file) and the JSUnit job was successful :) Thanks |
|
Did you guys also test folder upload with chrome ? I realized I forgot to test that part. |
|
Ok, folder upload still works. |
|
Awesome! thank you guys. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
From #10326 Fixes #8105
Thanks a lot @luckydonald
Would be good if people could give it a quick retest to make sure it still works.
I tested in Firefox and it seemed to work fine, although my computer/SSD is so fast I could only ever see the "2 seconds left" message.
👍 from me
Second review @rullzer @blizzz or others ?