Make sure files_external is loaded before accessing \OC_Mount_Config … #25334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or... we finally move the code to core. It is likely that this PR will always enable files_external at all times. |
fine by me |
|
Ref: #18160 |
|
So this PR will be included in 9.1? |
|
I think this PR is a bit dangerous since it might load apps "late". I'd prefer if we simply set the "enabled" flag in the files_external app and so we have it always enabled at setup time in 9.1 and 9.2. It would fix #22641 which is about running CLI commands after a CLI setup. |
|
better approach: #25422 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…- refs #22641