Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CachedMountInfo for user home storage #26017

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Update CachedMountInfo for user home storage #26017

merged 1 commit into from
Sep 7, 2016

Conversation

karakayasemi
Copy link
Contributor

@karakayasemi karakayasemi commented Sep 2, 2016

In getMountPointNode function rootId is not inside of the userFolder for home storage. We was searching '/user' folder in '/user/files' folder. So, it was return NULL. I moved searching part to parent folder. It solves everything. Also, obviously other storage types not affect then this change.

in getMountPointNode function rootId is not inside of the userFolder for home storage. We was searching '/user' folder in '/user/files' folder. So, it was return NULL. I moved searching part to parent folder.  It solves everything. Also, obviously other storage types not affect then this change.
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2016

CLA assistant check
All committers have signed the CLA.

@mention-bot
Copy link

@karakayasemi, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991 and @DeepDiver1975 to be potential reviewers

@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2016

@karakayasemi next time please mention me in your PR so I receive an email, I almost forgot about this. Thanks.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Sep 7, 2016
@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2016

Tested locally by logging the result of getMountPointNode() for the following:

  • "/sftp": system-wide ext storage
  • "/sftp-perso": personal external storage
  • "/test": received local share
  • "/test-fed": received federated share
  • "/admin": the current user's home
  • "/user1": the sharing user's home

Before, home nodes were null:

{"reqId":"rENH5tPAJE9BcmIoGPa2","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=19 path=\/user1\/files\/sftp","level":0,"time":"2016-09-07T09:35:21+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"rENH5tPAJE9BcmIoGPa2","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: null","level":0,"time":"2016-09-07T09:35:21+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"rENH5tPAJE9BcmIoGPa2","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=19 path=\/admin\/files\/sftp","level":0,"time":"2016-09-07T09:35:21+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"rENH5tPAJE9BcmIoGPa2","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=20 path=\/admin\/files\/sftp-perso","level":0,"time":"2016-09-07T09:35:21+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"rENH5tPAJE9BcmIoGPa2","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=17 path=\/admin\/files\/test","level":0,"time":"2016-09-07T09:35:21+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"rENH5tPAJE9BcmIoGPa2","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=45 path=\/admin\/files\/test-fed","level":0,"time":"2016-09-07T09:35:21+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"rENH5tPAJE9BcmIoGPa2","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: null","level":0,"time":"2016-09-07T09:35:21+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}

After:

{"reqId":"DJuz\/Sw5knClxbIaCzLs","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=19 path=\/user1\/files\/sftp","level":0,"time":"2016-09-07T09:34:30+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"DJuz\/Sw5knClxbIaCzLs","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=9 path=\/user1","level":0,"time":"2016-09-07T09:34:30+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"DJuz\/Sw5knClxbIaCzLs","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=19 path=\/admin\/files\/sftp","level":0,"time":"2016-09-07T09:34:30+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"DJuz\/Sw5knClxbIaCzLs","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=20 path=\/admin\/files\/sftp-perso","level":0,"time":"2016-09-07T09:34:30+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"DJuz\/Sw5knClxbIaCzLs","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=17 path=\/admin\/files\/test","level":0,"time":"2016-09-07T09:34:30+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"DJuz\/Sw5knClxbIaCzLs","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=45 path=\/admin\/files\/test-fed","level":0,"time":"2016-09-07T09:34:30+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}
{"reqId":"DJuz\/Sw5knClxbIaCzLs","remoteAddr":"127.0.0.1","app":"DEBUG","message":"Node: id=1 path=\/admin","level":0,"time":"2016-09-07T09:34:30+00:00","method":"PROPFIND","url":"\/owncloud\/remote.php\/webdav\/","user":"admin"}

👍

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants