Remove upload_limit in files app as it is not needed with PUT upload #26069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ogasser, @butonic and @LukasReschke to be potential reviewers |
6 tasks
PVince81
force-pushed
the
kill-uploadlimit
branch
from
e35d049
to
ffbf6b3
Compare
The web UI now uses for PUT uploads which aren't restricted by PHP's upload_max_filesize and post_max_size
PVince81
force-pushed
the
kill-uploadlimit
branch
from
ffbf6b3
to
a1b794a
Compare
|
Rebased, please review |
|
tested 👍 |
1 task
butonic
pushed a commit
that referenced
this pull request
Jan 18, 2017
…26069) The web UI now uses for PUT uploads which aren't restricted by PHP's upload_max_filesize and post_max_size
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove upload_limit in the files app as it's not needed any more.
Related Issue
Part of #26067
Motivation and Context
The web UI now uses for PUT uploads (see #21237) which aren't restricted by PHP's
upload_max_filesize and post_max_size. Cleaning this up removes additional unneeded logic and also prepares for #26067
How Has This Been Tested?
Edit
.htaccessand setupload_max_filesizeandpost_max_sizeto 5MB.Upload a 30 MB file in the files app.
Create a public link with edit permissions and upload a file there.
Types of changes
Checklist:
Note: I kept the admin page part because there might be third party apps still using the POST approach, so an admin should still be able to set a value.
@DeepDiver1975 @guruz