[stable9] Properly convert OCS params + more tests #26696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @SergioBertolinSG and @MorrisJobke to be potential reviewers. |
|
👍 |
|
Added read and share permissions instead of all (default ones) Added positive case Check also permissions update Added tests for resharing with public links when the user doesn't have enough permisssions
PVince81
force-pushed
the
stable9-publicupload-fix
branch
from
438108e
to
667903a
Compare
|
Rebased, tests should hopefully pass now |
Partial backport of the integration tests from #26610
|
Added 65af378 which backports some test functions |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26691 to stable9.
Retested manually, still works.
Note that I had to change the perms in the test from 15 to 7 because in OC <= 9.0 the public upload perms were missing the DELETE permission (known case that was adjusted in 9.1+).
@jvillafanez @SergioBertolinSG @DeepDiver1975