-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colon followed by number #26773
Fix colon followed by number #26773
Conversation
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @DeepDiver1975 and @davitol to be potential reviewers. |
@PVince81 will you upgrade sabre/uri on this PR ? This one is already merged sabre-io/uri#13 Tests are ok 👍 |
Yes, I'll upgrade sabre-uri in this PR. |
Added commit with the upgrade, let's see what CI says |
@DeepDiver1975 tests fail because of expected VObject version. Two possible solutions:
Since this is on master I think it's fine to update vobject for now, so I'll adjust the tests |
d7d6100
to
8b882cf
Compare
Oh well... while rebasing I had to do a |
All tests passed now, merge ? @SergioBertolinSG @DeepDiver1975 |
👍 |
To backport:
|
@SergioBertolinSG can you backport the tests ? |
Sure. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Related Issue
Fixes #25479
Motivation and Context
How Has This Been Tested?
Just run the integration test
Screenshots (if appropriate):
Types of changes
Checklist:
Backports:
@owncloud/qa