Fallback URI parser. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new implementation of PHP's parse_url. It's likely not perfect, but it catches specific cases that the built-in function does not support. Fixes Issue #9 Fixes Issue #11 @felixfbecker / @sii / @PVince81 Does this sufficiently solve your problem?
|
I think so, tests look good! |
|
Tested the patch and it fixes the colon issue in ownCloud, and as I can see the matching test case is included. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new implementation of PHP's parse_url. It's likely not
perfect, but it catches specific cases that the built-in function does
not support.
Fixes Issue #9
Fixes Issue #11
@felixfbecker / @sii / @PVince81 Does this sufficiently solve your
problem?