Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke the legacy storage fallback from orbit #26855

Merged
merged 2 commits into from
Dec 21, 2016

Conversation

PVince81
Copy link
Contributor

Description

Related Issue

Fixes #26325

Motivation and Context

Legacy storage has caused enough pain over the years, it's time for it to retire.
Also, a repair step should have fixed these when upgrading to OC 8.1.
In some cases it might have shown warnings and admins were advised to fix manually.

How Has This Been Tested?

Ran the unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@butonic @DeepDiver1975 @jvillafanez goodbye painful past

@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 to be a potential reviewer.

@DeepDiver1975
Copy link
Member

💥 👍

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Dec 21, 2016

Test\Files\FilesystemTest::testLegacyHomeMount
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'local::/dev/shm/data-autotest7/user_frbIG5T6hhu51/'
+'home::user_frbIG5T6hhu51'

/var/lib/jenkins/workspace/owncloud-core_core_PR-26855-TZMHA5JZWZ2YJIXHVEW4ICGLSW5F2F6WWSSFLE6CISVOGFG3WWOA/tests/lib/Files/FilesystemTest.php:477

@DeepDiver1975
Copy link
Member

@PVince81 really 💥

@PVince81
Copy link
Contributor Author

Oh, so there was another test for this. Good, I'll remove it.

@PVince81 PVince81 merged commit f3c0373 into master Dec 21, 2016
@PVince81 PVince81 deleted the obliterate-legacy-home-fallback branch December 21, 2016 15:52
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove local:: storage fallback
3 participants