Stable9.1 chunked web upload #26970
Stable9.1 chunked web upload #26970
Conversation
- uses PUT method with jquery.fileupload for regular and public file lists - for IE and browsers that don't support it, use POST with iframe transport - implemented Sabre plugin to handle iframe transport and redirect the embedded PUT request to the proper handler - added RFC5995 POST to file collection with "add-member" property to make it possible to auto-rename conflicting file names - remove obsolete ajax/upload.php and obsolete ajax routes
Not needed any more in IE >= 11
Hacked around Blueimp's jquery.fileupload to make it work with our new chunking API.
…26069) The web UI now uses for PUT uploads which aren't restricted by PHP's upload_max_filesize and post_max_size
Properly trigger the "stop" even from the uploader. Also update storage stats at the end of all uploads instead of for each upload.
Removes the need for POST to collection which would hit against upload limits. The client tries to auto rename the file by adding a suffix "(2)". It tries to use the file list on the client side to guess a suitable name. In case a file still cannot be uploaded and creates a conflict, which can happen when the file was concurrently uploaded, the logic will continue increasing the suffix.
|
✔️ with 4.6GB on IE11 🎉 @PVince81 is awesome! |
|
How can this even work ? We don't have Webdav PUT upload support in the JS code in 9.1 and from what I remember it was a huge change |
|
Hmm ok you backported everything... I'm not too happy to backport this huge change and change of behavior of 9.1. |
|
Had a chat with @DeepDiver1975 and he agreed that we should not backport this. This is a new feature in 10.0 and the code changes are too big. |
|
this is total madness - the feature is not even ready for master/10.0 and we are considering a backport? |
|
agreed. backport too risky. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
backport of #26306 to stable9.1
requires a few more commits to first enable PUT uploads.
manually tested in IE11, chrome canary and firefox.
cc @michaelstingl @PVince81