Fix long display names #27059
Fix long display names #27059
Conversation
append comma and count via html
add extra classes to be styled
drop formatRecipients tests, adapt tests, fix typo
drop formatRecipients tests, adapt tests, fix typo
…core into fix_long_display_names * 'fix_long_display_names' of https://github.com/owncloud/core: Drop formatRecipients() method, drop formatRecipients tests, adapt tests, fix typo
There was a problem hiding this comment.
Does this work with extraordinary long displaynames as shown in https://github.com/owncloud/enterprise/issues/1195 ?
reduce max shown names by 1
| @@ -166,7 +166,7 @@ describe('OCA.Sharing.Util tests', function() { | |||
| }]); | |||
| $tr = fileList.$el.find('tbody tr:first'); | |||
| $action = $tr.find('.action-share'); | |||
| expect($action.find('>span').text().trim()).toEqual('Shared with User One, User Two'); | |||
| expect($action.find('>span').text().trim()).toEqual('Shared with User One User Two'); | |||
There was a problem hiding this comment.
Since the comma will be added via CSS :after { content: "," }, there will be no comma separation in the result.
|
Steps:
|
|
this was with Chromium 55 |
| opacity: 0; | ||
| display: block; | ||
| float: left; | ||
| counter-increment: shared-with-recipient; |
There was a problem hiding this comment.
I feel old, never heard of this before. Wow, even IE11 supports this http://caniuse.com/#feat=css-counters
|
This brings me to the conclusion, that usernames need to be trimmed to a max length also. |
|
don't merge, the issues I mentionned were not fixed |
|
Will this solve the overlapping issue also in the "All files" view or rather only in the "Shared with others" one ? I am asking since the same issue has been reported in the "All files" view as well. |
|
Would it be possible to backport to 9.X version? |
|
No backport please. |
|
@felixheidecke can you fix open issues? |
|
Was fixed with #28872 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Motivation and Context
Using long display names causes problems in the "Shared with others" view of the files app wich leads to overlapping text. See https://github.com/owncloud/enterprise/issues/1195
How Has This Been Tested?
Browsertestet on latest
Screenshots (if appropriate):
Types of changes
Checklist: