Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disable third party apps on upgrade #27730

Merged
merged 2 commits into from
Apr 24, 2017

Conversation

PVince81
Copy link
Contributor

Description

Stop disabling them.

Related Issue

The market will update apps earlier in the upgrade process, it doesn't make much sense to disable them afterwards still: owncloud/market#39

Motivation and Context

Let's hope the market brings higher quality apps that don't break the upgrade process.

How Has This Been Tested?

Install contacts app, upgrade, app is still enabled.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 @VicDeo @butonic @cdamken

@PVince81 PVince81 added this to the 10.0 milestone Apr 24, 2017
@VicDeo
Copy link
Member

VicDeo commented Apr 24, 2017

👍 Jenkins cowardly refuses to approve. Let's wait for Travis.

@mmattel
Copy link
Contributor

mmattel commented Apr 24, 2017

Thanks ! (did not test...) This was really annyoing.

@PVince81 PVince81 merged commit 7f33109 into master Apr 24, 2017
@PVince81 PVince81 deleted the stop-disable-thirdparty-update branch April 24, 2017 11:09
@ghost
Copy link

ghost commented Apr 24, 2017

@PVince81 You might also want to close #14754

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants