Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce OWNCLOUD_CONFIG_DIR environment variable #27874

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

bachp
Copy link
Contributor

@bachp bachp commented May 12, 2017

Description

The environment variable OWNCLOUD_CONFIG_DIR allows to move the config out of the source tree. This is usefull to make the rest read-only.

Motivation and Context

Allow to have the source directory read-only.
Nextcloud has a similar variable called NEXTCLOUD_CONFIG_DIR so there it is already working.

How Has This Been Tested?

Running an Owncloud server 9.1.5 with a read only source directory.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This allosw to change the config location.
@CLAassistant
Copy link

CLAassistant commented May 12, 2017

CLA assistant check
All committers have signed the CLA.

@PVince81
Copy link
Contributor

Looks fine.

@DeepDiver1975 @butonic thoughts ?

@PVince81
Copy link
Contributor

Will need clear documentation because the config dir needs to be writable by the web server process, wherever it is. So all parent folders leading to it needs to be traversable by the web server process too.

I'd be tempted to say "not officially supported, use at your own risk"

@bachp
Copy link
Contributor Author

bachp commented May 15, 2017

I think this will be mostly used in special cases. For example NixOS uses it as the main code directory is read-only.

@bachp
Copy link
Contributor Author

bachp commented Jun 20, 2017

ping

@PVince81
Copy link
Contributor

Please raise a ticket in documentation repo: https://github.com/owncloud/documentation/

@PVince81 PVince81 merged commit 5573f77 into owncloud:master Jun 21, 2017
@patrickjahns
Copy link
Contributor

patrickjahns commented Jun 16, 2018

@PVince81 - this was never introduced in ownCloud 10 :'(

@tboerger
this would get rid for the need of having a symlink in the docker containers

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants