Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate all exception messages to the frontend #30800

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Propagate all exception messages to the frontend #30800

merged 1 commit into from
Mar 16, 2018

Conversation

IljaN
Copy link
Member

@IljaN IljaN commented Mar 16, 2018

Forward port of #30791

@IljaN IljaN requested a review from PVince81 March 16, 2018 13:05
@IljaN IljaN mentioned this pull request Mar 16, 2018
Merged
9 tasks
@codecov
Copy link

codecov bot commented Mar 16, 2018 •
edited
Loading

Codecov Report

Merging #30800 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #30800   +/-   ##
=========================================
  Coverage     61.97%   61.97%           
  Complexity    18352    18352           
=========================================
  Files          1157     1157           
  Lines         69051    69051           
  Branches       1242     1242           
=========================================
  Hits          42794    42794           
  Misses        25885    25885           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.33% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.06% <ø> (ø) 18352 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c49c86...893afc3. Read the comment docs.

PVince81
PVince81 approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the development milestone Mar 16, 2018
@IljaN IljaN merged commit 592cf1c into master Mar 16, 2018
@IljaN IljaN deleted the forward_port_propagate_move_errors_to_frontend branch March 16, 2018 14:45
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@IljaN IljaN

Labels
4 - To release
Projects
None yet
Milestone
10.0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@IljaN @PVince81