-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup federation phase 1 #32086
Cleanup federation phase 1 #32086
Conversation
238fe18
to
9350772
Compare
Codecov Report
@@ Coverage Diff @@
## master #32086 +/- ##
============================================
+ Coverage 63.85% 63.87% +0.02%
- Complexity 18556 18557 +1
============================================
Files 1169 1171 +2
Lines 69743 69753 +10
Branches 1267 1267
============================================
+ Hits 44535 44558 +23
+ Misses 24839 24826 -13
Partials 369 369
Continue to review full report at Codecov.
|
618847f
to
13bdf62
Compare
13bdf62
to
48e87c8
Compare
48e87c8
to
9c695cc
Compare
$args = \OC\Files\Filesystem::is_dir($file) | ||
? ['dir' => $file] | ||
: ['dir' => \dirname($file), 'scrollto' => $file]; | ||
$link = \OCP\Util::linkToAbsolute('files', 'index.php', $args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for later: we could use permalink here, see ViewController how to generate one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Please adjust the exception catch block I pointed to
} | ||
} catch (\Exception $e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better catch Share\Exceptions\ShareNotFound then and let the other through for proper error reporting ?
} | ||
$this->fedShareManager->declineShare($share); | ||
} catch (\Exception $e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -32,7 +32,7 @@ | |||
|
|||
$l = \OC::$server->getL10N('files_sharing'); | |||
|
|||
$federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application('federatedfilesharing'); | |||
$federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sad to see we still have ajax endpoints, oh well
@PVince81 updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
As discussed, unit tests will be added in the next round |
no backport for now |
Stable10: #33027 |
Description
The first part of federatedfileshare code cleanup
/ocs/routes.php
and set up absolute ocs routes in theappinfo/routes.php
Related Issue
https://github.com/owncloud/enterprise/issues/2564
Motivation and Context
Clean and readable code
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: