Cleanup federation phase 1 #32086
Merged
Cleanup federation phase 1 #32086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VicDeo
force-pushed
the
cleanup-federation-phase-1
branch
from
238fe18
to
9350772
Compare
Codecov Report
@@ Coverage Diff @@
## master #32086 +/- ##
============================================
+ Coverage 63.85% 63.87% +0.02%
- Complexity 18556 18557 +1
============================================
Files 1169 1171 +2
Lines 69743 69753 +10
Branches 1267 1267
============================================
+ Hits 44535 44558 +23
+ Misses 24839 24826 -13
Partials 369 369
Continue to review full report at Codecov.
|
VicDeo
force-pushed
the
cleanup-federation-phase-1
branch
6 times, most recently
from
618847f
to
13bdf62
Compare
VicDeo
force-pushed
the
cleanup-federation-phase-1
branch
from
13bdf62
to
48e87c8
Compare
VicDeo
force-pushed
the
cleanup-federation-phase-1
branch
from
48e87c8
to
9c695cc
Compare
PVince81
reviewed
Jul 20, 2018
| $args = \OC\Files\Filesystem::is_dir($file) | ||
| ? ['dir' => $file] | ||
| : ['dir' => \dirname($file), 'scrollto' => $file]; | ||
| $link = \OCP\Util::linkToAbsolute('files', 'index.php', $args); |
There was a problem hiding this comment.
note for later: we could use permalink here, see ViewController how to generate one
PVince81
suggested changes
Jul 20, 2018
| } | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
better catch Share\Exceptions\ShareNotFound then and let the other through for proper error reporting ?
| } | ||
| $this->fedShareManager->declineShare($share); | ||
| } catch (\Exception $e) { |
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| $l = \OC::$server->getL10N('files_sharing'); | |||
|
|
|||
| $federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application('federatedfilesharing'); | |||
| $federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application(); | |||
There was a problem hiding this comment.
sad to see we still have ajax endpoints, oh well
|
@PVince81 updated |
|
As discussed, unit tests will be added in the next round |
|
no backport for now |
|
Stable10: #33027 |
36 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first part of federatedfileshare code cleanup
/ocs/routes.phpand set up absolute ocs routes in theappinfo/routes.phpRelated Issue
https://github.com/owncloud/enterprise/issues/2564
Motivation and Context
Clean and readable code
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: