Allow remember login when external storage is disabled globally #33355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR can show "stay logged in" checkbox when external storage is disabled globally. |
|
thanks, but stay logged in is currently broken: #26027 also there was a reason for disabling when external storage is enabled but can't remember right now |
|
the reason was because of "save in session" and "save in DB" mode, in which case we need the user to login with actual credentials to be able to save these for external storage access. the remember me thing (if it wasn't broken as per #26027) might work because the user had to login at least once. however if external storages get configured by the admin, the admin would require those users to manually relogin with their password. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27051 and #15277 disable the feature "remember login". This means that
\OC_Util::rememberLoginAllowed()returnsfalsealways. We can enable it when external storage is disabled globally.