Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate coverage 2 #33509

Closed
wants to merge 2 commits into from
Closed

Investigate coverage 2 #33509

wants to merge 2 commits into from

Conversation

phil-davis
Copy link
Contributor

Add more test code to see what happens to codecov reports

@phil-davis phil-davis self-assigned this Nov 14, 2018
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #33509 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33509   +/-   ##
=========================================
  Coverage     64.08%   64.08%           
  Complexity    18302    18302           
=========================================
  Files          1192     1192           
  Lines         69145    69145           
  Branches       1277     1277           
=========================================
  Hits          44311    44311           
  Misses        24462    24462           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.91% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.38% <ø> (ø) 18302 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2802a5e...41e961a. Read the comment docs.

@phil-davis
Copy link
Contributor Author

This also passes codecov, so it does seem to be excluding acceptance test code OK.

@phil-davis phil-davis closed this Nov 14, 2018
@phil-davis phil-davis deleted the investigate-coverage-2 branch November 14, 2018 05:34
@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant