fix OCS Share API response for requests contain "include_tags" parameter

[karakayasemi]

Description

This PR simplifies tag generations for shares and fixes the duplicate share entry problem described in #37084 .
populateTags helper method is only used for tag generation for shares. There is no other usage of it in Github organization-wide. The method had too many nested loops. I simplified this method by customizing it for only shares.

@PVince81 Can you confirm the response with this PR so that I don't miss a thing?

Related Issue

• Fixes Duplicate link share entry in OCS response with favorites #37084

How Has This Been Tested?

• Described steps of Duplicate link share entry in OCS response with favorites #37084

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[PVince81]

I can't remember the reason for such complex code back then :-/

[PVince81]

Code looks fine. Can you add unit tests ?

[karakayasemi]

Code looks fine. Can you add unit tests ?

If the response is okay, I can add some tests.

[codecov]

Codecov Report

Merging #37088 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #37088      +/-   ##
============================================
+ Coverage     64.76%   64.78%   +0.02%     
+ Complexity    19136    19132       -4     
============================================
  Files          1270     1270              
  Lines         74915    74912       -3     
  Branches       1328     1328              
============================================
+ Hits          48517    48531      +14     
+ Misses        26008    25991      -17     
  Partials        390      390              

Flag	Coverage Δ	Complexity Δ
#javascript	54.18% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.96% <100.00%> (+0.02%)	19132.00 <5.00> (-4.00)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
apps/files/lib/Helper.php	38.77% <100.00%> (+14.50%)	35.00 <5.00> (-5.00)	⬆️
...es_sharing/lib/Controller/Share20OcsController.php	94.20% <100.00%> (+0.37%)	209.00 <0.00> (ø)
lib/private/Archive/Archive.php	72.22% <0.00%> (-5.56%)	10.00% <0.00%> (ø%)
lib/private/Session/Internal.php	0.00% <0.00%> (ø)	26.00% <0.00%> (+1.00%)
lib/base.php	3.83% <0.00%> (+0.01%)	151.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d797555...a35be4d. Read the comment docs.

[PVince81]

I've retested on Phoenix with my scenario and there are no more duplicates. Thanks!

[karakayasemi]

@PVince81 Manipulating ShareController tests is pretty complicated. I changed some ApiTest tests to cover requests with "include_tags = true" parameter.

[PVince81]

👍 from me. Would be good to also get approval from @micbar

[micbar]

@karakayasemi Can you describe the way it was fixed? "Reduced the complexity of ..."

[karakayasemi]

@micbar I extended the changelog entry with more details. Please, review one more time. Thanks.

[micbar]

👍