[Tests-Only] Refactors for failing tests in ldap

[jasson99]

Description

Refactor a function for the ldap tests to pass correctly

Related Issue

Part of owncloud/user_ldap#570

Motivation and Context

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[phil-davis]

@jasson99 I found another problem call to substituteInLineCodes in LoggingContext so I pushed that also, and rebased the PR to latest master.

[codecov]

Codecov Report

Merging #37483 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37483   +/-   ##
=========================================
  Coverage     64.67%   64.67%           
  Complexity    19335    19335           
=========================================
  Files          1277     1277           
  Lines         75533    75533           
  Branches       1331     1331           
=========================================
  Hits          48849    48849           
  Misses        26292    26292           
  Partials        392      392           

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.83% <ø> (ø)	19335.00 <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e8c33...9a35b8c. Read the comment docs.