Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The response of LOCK shall hold the updated owner set by the LockManager #37647

Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jul 3, 2020

Description

In case the owner is updated by the server within the LOCK operation the updated owner value needs to be sent back to the client

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #37647 into master will increase coverage by 20.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #37647       +/-   ##
=============================================
+ Coverage     44.32%   64.74%   +20.41%     
- Complexity        0    19360    +19360     
=============================================
  Files           111     1281     +1170     
  Lines         10967    75622    +64655     
  Branches       1333     1333               
=============================================
+ Hits           4861    48959    +44098     
- Misses         5714    26271    +20557     
  Partials        392      392               
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.92% <100.00%> (+42.84%) 19360.00 <0.00> (+19360.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/Lock/Persistent/LockManager.php 98.30% <100.00%> (ø) 23.00 <0.00> (?)
lib/private/Http/Client/Response.php 53.84% <0.00%> (ø) 6.00% <0.00%> (?%)
lib/private/DB/SQLiteMigrator.php 100.00% <0.00%> (ø) 7.00% <0.00%> (?%)
...v/lib/Connector/Sabre/Exception/EntityTooLarge.php 0.00% <0.00%> (ø) 1.00% <0.00%> (?%)
settings/Panels/Admin/Logging.php 100.00% <0.00%> (ø) 5.00% <0.00%> (?%)
apps/dav/lib/Avatars/AvatarNode.php 72.00% <0.00%> (ø) 9.00% <0.00%> (?%)
lib/public/Util.php 58.85% <0.00%> (ø) 81.00% <0.00%> (?%)
lib/private/Command/QueueBus.php 84.61% <0.00%> (ø) 6.00% <0.00%> (?%)
lib/private/Files/External/PriorityTrait.php 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...ilesharing/templates/settings-personal-general.php 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 1163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cac52e...8c1c3fb. Read the comment docs.

@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/response-of-lock-needs-to-update-the-owner branch from c4a693c to 17178bf Compare July 3, 2020 12:04
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/response-of-lock-needs-to-update-the-owner branch from 17178bf to 8c1c3fb Compare July 3, 2020 12:12
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@owncloud owncloud deleted a comment from update-docs bot Jul 3, 2020
@phil-davis phil-davis merged commit fb7950d into master Jul 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/response-of-lock-needs-to-update-the-owner branch July 3, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants