improve-public-share-interface #38712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
AlexAndBear
force-pushed
the
improve-public-share-interface
branch
from
2c6ce78
to
862cfee
Compare
|
@JammingBen pre-review is welcome 🐰 |
JammingBen
reviewed
May 10, 2021
AlexAndBear
force-pushed
the
improve-public-share-interface
branch
2 times, most recently
from
e093bb5
to
0e8e065
Compare
|
@phil-davis Patrick told me that, you are a quite good text reviewer, can you look at the texts for the oc.dialogs.drop maybe :) ? |
AlexAndBear
force-pushed
the
improve-public-share-interface
branch
from
d67cf77
to
f2cfe49
Compare
AlexAndBear
force-pushed
the
improve-public-share-interface
branch
from
7a2e827
to
db15d7e
Compare
VicDeo
requested changes
May 19, 2021
There was a problem hiding this comment.
Cool improvement but it needs to respect the setups where OC is located in the subfolder of the server webroot:
- Install OC into
localhost/owncloud - Create a public folder share
- Open it as a guest user
- Click 'Add to localhost'
Expected
login screen
Actual
HTTP 404
as it requests
http://localhost/index.php/apps/files# instead of
http://localhost/owncloud/index.php/apps/files#
AlexAndBear
force-pushed
the
improve-public-share-interface
branch
from
db15d7e
to
52aed0b
Compare
|
@VicDeo good catch, thx! can you try again? |
VicDeo
reviewed
May 19, 2021
AlexAndBear
force-pushed
the
improve-public-share-interface
branch
from
d617745
to
be707c2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
VicDeo
approved these changes
May 19, 2021
This was referenced May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adjustment provides a new way to add a public share to ownCloud.
A new button will be displayed where you can easily add the share to the current
server without entering the string, this requires less user input.
Next to this button, a dropdown menu will be displayed,
where you can see the current server or change the server.
Hitting change a server will now display a prompt with a detailed explanation
and more space to enter another server address.
Related Issue
Tested on
Screenshots (if appropriate):
Before:
After:
Types of changes
Checklist: