Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] split apiShareOperationsTo... suites to reduce run time #38848

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 15, 2021

Description

apiShareOperationsToShares acceptance test suite has been taking a long time to run - about 1 hour. It is the longest-running test pipeline. That is because new test scenarios were added to shareAccessByID.feature recently.

This PR splits apiShareOperationsToRoot and apiShareOperationsToShares into 2 parts each. That will reduce the elapsed time ffor CI to finish.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

Note: apiTrashbin is now the longest-running pipeline - about 50 minutes. That is similar to the total of PHP unit tests with Oracle plus the SonarCloud analysis pipeline. So those are the 2 things that can be looked at to next reduce the elapsed time of CI on a PR.

@phil-davis phil-davis merged commit 9e81791 into master Jun 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the split-long-sharing-test-suites branch June 15, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants