Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only]Adjust webdav previews test according to its behaviour in ocis #38849

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

jasson99
Copy link
Contributor

Description

This PR adjusts a webdav previews test which was failing in ocis and hence was included in the expected failures file. However, the test involved downloading a received share for preview. For that reason, in ocis, the share should be accepted first. Hence, the adjustment of the test is made accordingly in this pr.

Related Issue

owncloud/ocis#2078

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jasson99 jasson99 self-assigned this Jun 15, 2021
@jasson99 jasson99 requested review from individual-it, kiranparajuli589, dpakach and swoichha and removed request for individual-it June 15, 2021 08:20
@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 72c44c6 into master Jun 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjustPreviewsTestsInvolvingReceivedShares branch June 15, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants