Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show mail in lock owner data if mail adress is empty string #39292

Merged
merged 5 commits into from
Sep 28, 2021

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Sep 27, 2021

Description

Bugfix: Don't show empty brackets in lock owner information if mail not set

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear marked this pull request as ready for review September 27, 2021 08:46
@AlexAndBear AlexAndBear self-assigned this Sep 27, 2021
@owncloud owncloud deleted a comment from update-docs bot Sep 27, 2021
@AlexAndBear
Copy link
Author

On the other hand we can just remove the extra () field as @DeepDiver1975 suggested in the recent issue

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works.

Note: to get this problem in the first place, an email address has to have been set for/by a new user. Then the user deleted the email address (sets it to the empty string, effectively). If a user never ever had an email address then this problem did not happen - the user's email address was effectively null.

Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage?

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 3a7a882 into master Sep 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/37878 branch September 28, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock owner has extra brackets at end
4 participants