-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show mail in lock owner data if mail adress is empty string #39292
Conversation
On the other hand we can just remove the extra () field as @DeepDiver1975 suggested in the recent issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works.
Note: to get this problem in the first place, an email address has to have been set for/by a new user. Then the user deleted the email address (sets it to the empty string, effectively). If a user never ever had an email address then this problem did not happen - the user's email address was effectively null
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage?
Kudos, SonarCloud Quality Gate passed! |
Description
Bugfix: Don't show empty brackets in lock owner information if mail not set
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: