Allow setting multiple default file actions

[JammingBen]

Description

This change allows a mime type to have multiple default file actions. In the past, registering an action as default would overwrite existing defaults.

In case multiple file actions apply to a mime type, clicking on a file will show the app drawer context menu.

This approach allows apps to control where their actions will be displayed and is also more clean than the old and confusing getActionsWithoutAll method.

Related Issue

• Fixes https://github.com/owncloud/enterprise/issues/4634
• Fixes "Open with" menu in ownCloud ONLYOFFICE/onlyoffice-owncloud#365

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised: Allow setting multiple default file actions docs#4439
• Changelog item, see TEMPLATE

[ownclouders]

💥 Acceptance tests pipeline webUIFileActionsMenu-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33845/154/1

[ownclouders]

💥 Acceptance tests pipeline apiProxySmoke-8-3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33846/172/1

[JammingBen]

The changes look more "drastic" than they actually are. Many of the things that were introduced with #38132 have been rolled back.

• Remove _getActions(), use getActions() instead.
• Remove getActionsWithoutAll() because not needed anymore.
• Implement getDefaultFileActions().
• Deprecate getDefaultFileAction(). It still behaves like before to ensure nothing breaks.

As discussed with @pmaier1 we'd like to have this in 10.9.

[phil-davis]

Is there a combination of apps that we can use to test this, without having OnlyOffice installed?

[JammingBen]

Is there a combination of apps that we can use to test this, without having OnlyOffice installed?

Gallery and Medaviewer should work. They both register their actions as default for images.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

96.1% Coverage
0.0% Duplication

[mmattel]

I guess that this is docs relevant...

[JammingBen]

Thx for the hint, I created owncloud/docs#4439. It needs some groundwork first, I'll take care as this is quite technical.