Added SVG fallback to apps settings popup

[tsumi]

This fix issue of calendar app with IE8, see issue report for details:
owncloud/calendar#291

Tested with Firefox 26/Linux and IE8/Windows 7, seem work fine without JS errors or other unexpected effects, please double check.

[ghost]

Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/ Alternatively you can add a comment here where you state that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

[tsumi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I release this contribution under MIT license.

Ref.: https://github.com/owncloud/core/pull/6721

Andrea Boero
http://www.tsumi.it
mail [at] tsumi.it
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJS0FoWAAoJEPq8DiGiTvpmBVsP/jwTIRKRaBhvygu2ShMJUGU/
mqJAhKFEJgKzlOqwOGDspLDefikMe1NBdMneENDw8sqm1v1FBmQxGG7/jNgBV82g
1axrgwbuQJBftQXNQwA2yTT9GYZikBOcMyGsiz3GYgYa6PAEm8two8A8udW3+rJG
6/5E7HvUwlvxRlacKh+9eL9nV4OQU6lbaEgQHNjt7dFv+bCT5Y6QVURcztqtLEPf
aN5PC4sSq4Zi3SZXFh9quro008n/BYecJhHG+0yEavLxbjtX6qw+Syt7lS8g9Hex
/Assi5sbLyfawyUVwGJTvAvuXI43h6z4K38aL00Zpv8wfG0TFKs9ig+eMooX/2o5
AloS9OlAYIw85+16I3jpHQ5Dz1MCJTHZIQFqUL+/PHl71HIgqj0yEntVYg0uN3mo
65D6lvOaVJ/6oLhswZxL6m5MOYN8GfxXadVbcEvm0dEYeqbBOQNzykiBRnwEO8yZ
qJkr3ATyu93MK23yOQXTOyO0qjLQhAW4kRxjASRcDpidglOx56Km033DLAIR/sS6
s94TMgN866j4DLn56kJJNnlc2ewrvlOVioeDNPnsSTVRW0/FWNfOYmrlC3znrrF0
jPkyTDDScosfSc0/OG9THJuv523sIjWKExGqa1uoIfRqRRHCRymBQ4imWM3l/Hcv
em04pj8C5PwhpNSkQhRI
=/MJ6
-----END PGP SIGNATURE-----

[DeepDiver1975]

@owncloud-bot ok to test

[DeepDiver1975]

@tsumi thanks for your license agreement

[tsumi]

As noticed in owncloud/calendar#291 also OC 5.x is affected.
I think (i must check and test it, but i quite sure) that my fix can be applied to OC5.x too, should i open a pull request for 5.x branch too?

[PVince81]

It looks like checkMimeType is already called in row 714 and as far as I understand it only needs to be called once.

It might be enough to just call replaceSVG when !SVGSupport() returns true ?

[tsumi]

@PVince81 i checked the code of SVGSupport.checkMimeType(); and you are right... only active things that it can do are:

• set SVGSupport.checkMimeType.correct=false; that cause SVGSupport() return always false (that is set on first execution, if needed)
• call again replaceSVG(); (useless at this point)

[ghost]

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2602/

[PVince81]

Tested in:

• Chrome 31
• Firefox 26
• IE8 (XP)
• IE9 (Win7)

Code looks good.
👍

This needs a second reviewer: @kabum @jancborchardt @georgehrke

[PVince81]

@tsumi btw nice gpg signature 😉

[MorrisJobke]

👍 (IE8, Chrome, Firefox)