Type hinting fixes #8222
Merged
Type hinting fixes #8222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using scrutinizer patch
using scrutinizer patch
|
A new inspection was created. |
|
💣 Test Failed. 💣 |
| * Get the directory for the given app. | ||
| * If the app is defined in multiple directories, the first one is taken. (false if not found) | ||
| * @param string $appid | ||
| * @return string|false |
There was a problem hiding this comment.
This function can return false, not likely but still
|
@owncloud-bot retest this please |
|
otherwise 👍 |
|
🚀 Test Passed. 🚀 |
|
Not that i think those should return false, but it can happen at the moment |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@icewind1991 @DeepDiver1975 please review
changes suggested by scrutinizer