Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] instance.sh suggests to run occ upgrade while still in maintenance mode #809

Closed
jnweiger opened this issue Jan 24, 2023 · 1 comment · Fixed by #810
Closed

[QA] instance.sh suggests to run occ upgrade while still in maintenance mode #809

jnweiger opened this issue Jan 24, 2023 · 1 comment · Fixed by #810
Assignees

Comments

@jnweiger
Copy link
Contributor

Seen while testing the scripts presented in
https://github.com/owncloud/docs-server/edit/10.11/modules/admin_manual/pages/installation/manual_installation/script_guided_install.adoc

Usecase: upgrade from oc10.11 to master

After the script is run, amongst others, this sequence of actions is suggested:

Please manually run: sudo -u www-data ./occ upgrade
Copy any changes manually added in .user.ini and .htaccess from the backup directory
Please manually run: sudo -u www-data ./occ maintenance:mode --off

As instance.sh initially asked us to put the server in maintenance mode, the occ upgrade command will be attempted in maintenance mode, and this fails:

sudo -u www-data ./occ upgrade
ownCloud is in maintenance mode - no app have been loaded

<warning>ownCloud is in maintenance mode</warning>
Maybe an upgrade is already in process. Please check the logfile (data/owncloud.log). If you want to re-run the upgrade procedure, remove the "maintenance mode" from config.php and call this script again.

Expected behavior:

  • a sequence of commands that agrees with occ usage.
  • first maintenance mode off, then upgrade.
@mmattel
Copy link
Contributor

mmattel commented Jan 25, 2023

Thanks for catching, fix is on the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants