-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] fails to connect with new credentials #164
Comments
For 2.0.0-rc.2 we updated some dependencies #135 To make it work again. Maybe this is needed again? |
I suppose that the existing 2.0.0 and 2.0.1 releases have this problem? This app only has unit tests, which are not going to be making real connections to a real current dropbox interface. I remember thinking about how to have automated acceptance tests, but it is a similar problem to the SMB tests (which rely on haing a Windows Server set up with known credentials etc.). There has to be a real dropbox account of some sort available to test against in CI. What is the situation for this app? Are there installations using it in production that need it bundled in the core release? Or will it be acceptable to unbundle it from the core release, and work on sorting it out with less priority? |
I suspect that this comment is correct: "As dropbox now only work with short lived tokens, new created connections do not work any more. Connections are going to get a relatively short-lived access token, and be able to use a refresh token to keep getting a new access token when needed. And code "somewhere" is going to have to handle that. The dependencies https://github.com/Hemant-Mann/flysystem-dropbox and https://github.com/kunalvarma05/dropbox-php-sdk don't have any recent releases. I am no familiar with the code, so without looking at it in detail, I don't know if the token refresh logic/timing is supposed to be embedded in that dropbox-php-sdk, or if our oC10 app has to do that work. |
I have adjusted the redirect url (have now both, with and without /index.php/...) But, the folder is not really connected.
News from the server log:
|
Ok, past my bed time here! I will try setting up a connection to a real dropbox tomorrow and see what happens. |
Seen with 2.0.2 and core 10.15.0-rc.3. Not a regression: Also seen with 2.0.1
Mabye related to #113 ?
Workaround:
The text was updated successfully, but these errors were encountered: