php-cs-fixer version used is different (lower) compared to core

[mmattel]

I have seen that the version of php-cs-fixer used is different compared to core.
I compared both composer.lock files.

Background
php-cs-fixer errors in PR #112 with:

Files that were not fixed due to errors reported during linting before fixing:
   1) /drone/server/apps/files_primary_s3/lib/command/list.php

According to
https://stackoverflow.com/questions/51667079/netbeans-php-cs-fixer-end-up-with-error-files-that-were-not-fixed-due-to-errors
this could be due to an error of the used version and is possibly fixed by an update

core

           "require-dev": {
                "friendsofphp/php-cs-fixer": "2.2.*",

files_primary_s3

            "name": "friendsofphp/php-cs-fixer",
            "version": "v2.12.1",
            "source": {
                "type": "git",
                "url": "https://github.com/FriendsOfPHP/PHP-CS-Fixer.git",
                "reference": "beef6cbe6dec7205edcd143842a49f9a691859a6"
            },

@phil-davis @DeepDiver1975

[ownclouders]

GitMate.io thinks a possibly related issue is #55 (php-cs-fixer).

[phil-davis]

PR #114 bumps all the little things that are waiting.
We could do a PR just to bump friendsofphp/php-cs-fixer but it looks easy/safe enough to do everything.

[patrickjahns]

Thanks for raising - however - it is not critical.

Generally speaking - we will move forward with having CLI tools like php-cs-fixer / phan / phpstan etc. in a seperate namespace ( via composer-bin-plugin ) so the dependencies of these tools are segregated.

I would not go forward with providing any manual version bumps - dependabot should be used for this. If it is not working as intended, please raise a ticket and we need to schedule time to look into it

[phil-davis]

The bot had found a few things. But that php-cs-fixer bump has been "out there on the internet" for some time (and has a fix for something I reported...). Somehow the bot had not noticed it - maybe the bot was not looking at the dependencies under owncloud/coding-standard ?

[patrickjahns]

@phil-davis

The bot did find everything that is officially published: https://packagist.org/packages/owncloud/coding-standard

As we locked php-cs-fixer with 1.0.1 of the coding-standard to a specific version, and your fix didn't trigger a release.

Opened an issue here: owncloud/coding-standard#14

[DeepDiver1975]

PR #114 bumps all the little things that are waiting.

I think we can close this - the PR is merged.