-
Notifications
You must be signed in to change notification settings - Fork 76
Conversation
By analyzing the blame information on this pull request, we identified @jancborchardt, @ChristophWurst and @DeepDiver1975 to be potential reviewers |
Ahahahahahahhahaha! You're the best Christoph! 💯 |
Yooo, have yet to test cause I'm on mobile but that looks pretty damn cool! :) Great work |
@jancborchardt I thought you have your dev env on the smartphone? :P |
Hmmm, the problem though is that when there’s a scrollbar (like when you expand the collapsed folders), that scrollbar will be obstructed by the New Message button background … ;) Which is exactly why the hackery was in place. @skjnldsv |
@jancborchardt I don't have this problem at all on my device :) |
The new message is out of the scroll section, so the scrollbar will be contained to the list only, no risk of it being hidden by an other element. |
That was the visual point though, to have it in the same area. Now the sidebar feels cramped cause the list is cut off both at top and bottom. :/ |
I don't think it looks cramped because mostly there are only a few items in there as the folders are collapsed by default now :-/ |
The sidebar is also a visual indicator. You should only have a scrollbar on scrollable elements, not just on a global div which only move a part of the page. |
Fix some misused css data and reorder the sidebar layout to have a full width new message button without the need of js.
refs #1463
@ChristophWurst