Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return proper error description for auth-core/refresh-token errors #279

Merged
merged 1 commit into from
Jan 12, 2021
Merged

return proper error description for auth-core/refresh-token errors #279

merged 1 commit into from
Jan 12, 2021

Conversation

mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Jan 11, 2021 •
edited
Loading

@mrow4a mrow4a self-assigned this Jan 11, 2021
@CLAassistant
Copy link

CLAassistant commented Jan 11, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@VicDeo
Copy link
Member

VicDeo commented Jan 12, 2021 •
edited
Loading

@mrow4a if error_description is supposed to be exposed to the user it would be good to have it translated.

@mrow4a
Copy link
Contributor Author

mrow4a commented Jan 12, 2021

@mrow4a if error_description is supposed to be exposed to the user it would be good to have it translated.

hmm, this is usually debugging information that is returned by OAuth. They are rather not translated.

@mrow4a
Copy link
Contributor Author

mrow4a commented Jan 12, 2021

@micbar can be merged?

@micbar
Copy link
Contributor

micbar commented Jan 12, 2021

yes, all green

@mrow4a mrow4a merged commit abe6662 into master Jan 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix/return-error-description branch January 12, 2021 18:11
@pmaier1 pmaier1 mentioned this pull request Aug 11, 2021
Closed
41 tasks
@jnweiger jnweiger mentioned this pull request Sep 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VicDeo VicDeo VicDeo approved these changes

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

Assignees

@mrow4a mrow4a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrow4a @CLAassistant @VicDeo @micbar