Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use safehtml/template instead html/template #6411

Closed
kobergj opened this issue May 30, 2023 · 1 comment · Fixed by #6429
Closed

Use safehtml/template instead html/template #6411

kobergj opened this issue May 30, 2023 · 1 comment · Fixed by #6429
Assignees
@2403905
Labels
Type:Bug

Comments

@kobergj
Copy link
Collaborator

kobergj commented May 30, 2023

External Code Review suggest to use safehtml/template pkg instead html/template for creating email templates (services/notifications/pkg/email/email.go).

In our case this is not a security issue as we fully control the source. However the fix wouldn't hurt and is indeed best practice.
@kobergj kobergj mentioned this issue May 30, 2023
Closed
@kobergj
Copy link
Collaborator Author

kobergj commented May 31, 2023

Simple test showed safehtml breaks email formatting. Needs to be properly planned and estimated.

This was referenced May 31, 2023
Closed
Merged
@2403905 2403905 self-assigned this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2403905 2403905

Labels
Type:Bug
Projects
None yet
Milestone
No milestone
2 participants
@2403905 @kobergj