Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: re-index command for all spaces #9103

Closed
wkloucek opened this issue May 8, 2024 · 3 comments · Fixed by #9456
Closed

search: re-index command for all spaces #9103

wkloucek opened this issue May 8, 2024 · 3 comments · Fixed by #9456
Assignees

Comments

@wkloucek
Copy link
Contributor

wkloucek commented May 8, 2024

Is your feature request related to a problem? Please describe.

My guess is that the ocis search index --space $SPACE_ID --user $USER_ID dates back to the times before we had a service account.

Therefore it needs the space id and a user id that has access to that space.

Describe the solution you'd like

Leverage the service account for search, so that it can discover all spaces by itself and we can trigger re-indexing for all spaces with one command.

Ideally this would be eg.:

ocis search index or ocis search index --all-spaces

Describe alternatives you've considered

Get a list of all spaces and a member each. But that requires permissions to list the spaces graph endpoint and therefore a OIDC session. Currently this can not really easily automated, while the proposed solution is very easy to be triggered in a automated way.

Additional context

none

@mmattel
Copy link
Contributor

mmattel commented May 17, 2024

Referencing: #5515 (Improve the search service index management)

@kobergj
Copy link
Collaborator

kobergj commented Jun 24, 2024

Ideally this would be eg.:

ocis search index or ocis search index --all-spaces

I did go for ocis search index --all-spaces. Somebody typing ocis search index (without parameters) might expect to see the help message and not start a timeconsuming reindex of all spaces.

Btw: search service already used service accounts. The --user param is unused and can be omitted. I removed it.

@micbar
Copy link
Contributor

micbar commented Jun 27, 2024

@kobergj Can you update the README of the search service?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants