Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill in the missing parts for accept, decline and delete shares #985

Closed
exalate-issue-sync bot opened this issue Nov 30, 2020 · 3 comments · Fixed by owncloud/web#4433
Closed

Fill in the missing parts for accept, decline and delete shares #985

exalate-issue-sync bot opened this issue Nov 30, 2020 · 3 comments · Fixed by owncloud/web#4433
Labels
Type:Story User Story

Comments

@exalate-issue-sync
Copy link

The shared with me page has a Status column. This column correctly shows Pending or Rejected, but never an Accepted status for accepted shares. We know when a share is accepted so we should just show this status as well.
@exalate-issue-sync exalate-issue-sync bot changed the title [oC-Web] there is no Accepted status in shared with me Fill in the missing parts for accept, decline and delete shares Dec 7, 2020
@exalate-issue-sync exalate-issue-sync bot added story and removed bug labels Dec 7, 2020
@C0rby C0rby mentioned this issue Dec 8, 2020
Merged
@exalate-issue-sync
Copy link
Author

Benedikt Kulmann commented: [~dchristofas] what about a Decline action, should that be inlined with the Accepted status? In theory we have the Delete action in the right sidebar. There is this issue https://jira.owncloud.com/browse/OCIS-1035 - maybe that's sufficient.

@exalate-issue-sync
Copy link
Author

exalate-issue-sync bot commented Dec 8, 2020 •
edited

David Christofas commented: Hm, I'm in favor of a Decline action instead of a Delete action.
In the context of shares it's more clear I belive.

Should it be implemented in this ticket?

@exalate-issue-sync
Copy link
Author

Benedikt Kulmann commented: Can you make it a subtask? And also add the (already solved) Accepted status label as another subtask?
Maybe there are other things to do to make this coherent.

C0rby pushed a commit to owncloud/web that referenced this issue Dec 8, 2020
add the option to retroactively decline an accepted share
6ee93d9 
Implements owncloud/ocis#985
@C0rby C0rby mentioned this issue Dec 8, 2020
Merged
@exalate-issue-sync exalate-issue-sync bot reopened this Dec 8, 2020
@settings settings bot removed the story label Jan 12, 2021
@exalate-issue-sync exalate-issue-sync bot added the Type:Story User Story label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type:Story User Story
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add status text for accepted shares owncloud/web
0 participants